0.35.6: Log4j and JUnit are in the compile scope

[markkolich]

Hi @vsch ... I upgraded my project from version 0.35.0 to 0.35.6 and am now seeing junit:junit and log4j:log4j in the compile scope:

[INFO] +- com.vladsch.flexmark:flexmark:jar:0.35.6:compile
[INFO]   +- com.vladsch.flexmark:flexmark-test-util:jar:0.35.6:compile
[INFO]   |  \- junit:junit:jar:4.12:compile << -- !!
[INFO]   |     \- org.hamcrest:hamcrest-core:jar:1.3:compile
[INFO]   +- com.vladsch.flexmark:flexmark-util:jar:0.35.6:compile
[INFO]   \- log4j:log4j:jar:1.2.17:compile << -- !!

I believe these dependencies were meant to stay in the test scope?

CC // @larrysteinke

[vsch]

@markkolich, thanks for catching it. I missed a few dependencies and had debug code left in the document parser.

Next release, coming in an hour or so will have these fixed.

[markkolich]

Thanks @vsch!

Fwiw, I only noticed this because I'm using the maven-enforcer-plugin in my project to keep "banned dependencies" out of my classpath:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-enforcer-plugin</artifactId>
    <version>3.0.0-M2</version>
    <executions>
    <execution>
        <id>enforce-banned-dependencies</id>
        <phase>prepare-package</phase>
        <goals>
            <goal>enforce</goal>
        </goals>
        <configuration>
            <rules>
              <requireUpperBoundDeps/>
              <bannedDependencies>
                  <!-- List of artifacts to ban -->
                  <excludes>
                      <exclude>log4j:log4j:compile</exclude>
                      <exclude>junit:junit:compile</exclude>

                      <exclude>org.apache.logging.log4j:log4j-api</exclude>
                      <exclude>org.apache.logging.log4j:log4j-core</exclude>
                      <exclude>commons-logging:commons-logging</exclude>
                  </excludes>
              </bannedDependencies>
            </rules>
            <!-- Fail on the first rule that doesn't pass. -->
            <failFast>true</failFast>
            </configuration>
        </execution>
    </executions>
</plugin>

[vsch]

@markkolich, repo updated. Be careful if forking. Old, Java 9 incompatible version is in branch v0.35, and version 0.35.8 was updated on maven.

Version 0.40.0 and up are made Java 9+ module compatible and will break existing code without migration.