Skip to content

Report sum stat for numerical columns to DF #7567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AdamGS wants to merge 1 commit into
base: develop
Choose a base branch
from
+30 −6
Draft

Report sum stat for numerical columns to DF #7567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions vortex-array/src/expr/stats/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,9 @@ impl Stat {
Self::NullCount => DType::Primitive(PType::U64, NonNullable),
Self::UncompressedSizeInBytes => DType::Primitive(PType::U64, NonNullable),
Self::NaNCount => {
return aggregate_fn::fns::nan_count::NanCount
.return_dtype(&EmptyOptions, data_type);
}
Self::Sum => {
return aggregate_fn::fns::sum::Sum.return_dtype(&EmptyOptions, data_type);
aggregate_fn::fns::nan_count::NanCount.return_dtype(&EmptyOptions, data_type)?
}
Self::Sum => aggregate_fn::fns::sum::Sum.return_dtype(&EmptyOptions, data_type)?,
})
}

Expand Down
29 changes: 28 additions & 1 deletion vortex-datafusion/src/persistent/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use std::fmt::Debug;
use std::fmt::Formatter;
use std::sync::Arc;

use arrow_schema::DataType;
use arrow_schema::Schema;
use arrow_schema::SchemaRef;
use async_trait::async_trait;
Expand Down Expand Up @@ -568,13 +569,39 @@ impl FileFormat for VortexFormat {
.transpose()
});

let sum = (!matches!(field.data_type(), DataType::Boolean))
.then(|| {
stats_set.get(Stat::Sum).and_then(|pstat_val| {
{
Stat::Sum.dtype(stats_dtype).map(|stat_dtype| {
pstat_val
.map(|stat_val| {
Scalar::try_new(stat_dtype, Some(stat_val))
.vortex_expect(
"`Stat::Sum` somehow had an incompatible `DType`",
)
.cast(&DType::from_arrow(field.as_ref()))
.vortex_expect(
"Unable to cast to target type that DataFusion wants",
)
.try_to_df()
.ok()
})
.transpose()
})
}
.flatten()
})
})
.flatten();

let null_count = stats_set.get_as::<usize>(Stat::NullCount, &PType::U64.into());

column_statistics.push(ColumnStatistics {
null_count: null_count.to_df(),
min_value: min.to_df(),
max_value: max.to_df(),
sum_value: Precision::Absent,
sum_value: sum.to_df(),
distinct_count: stats_set
.get_as::<bool>(Stat::IsConstant, &DType::Bool(Nullability::NonNullable))
.and_then(|is_constant| is_constant.as_exact().map(|_| Precision::Exact(1)))
Expand Down
Loading