Open
Conversation
robert3005
commented
Apr 16, 2026
robert3005
commented
Apr 16, 2026
Contributor
Author
|
Looks like we want to invert defaults here where the cast by default is name based from talking to @gatesn |
Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will improve performance by 32.81%
Performance Changes
Comparing Footnotes
|
Signed-off-by: Robert Kruszewski <github@robertk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to handle full generality of casts we need to distinguish between
casting fields by name and by position. The positional casts are useful for non
sql systems where names are just metadata and the order of values matters.
However, in order to integrate with sql systesm we need by names casts as well.
It's not possible to handle them without any indication from the user which
behaviour they care about
fix #6900
Signed-off-by: Robert Kruszewski github@robertk.io