perf: idempotent_dir for dataset generation#7493
Open
joseph-isaacs wants to merge 3 commits intodevelopfrom
Open
perf: idempotent_dir for dataset generation#7493joseph-isaacs wants to merge 3 commits intodevelopfrom
joseph-isaacs wants to merge 3 commits intodevelopfrom
Conversation
joseph-isaacs
added
the
action/benchmark
github-actions
Bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.952x ➖ datafusion / vortex-file-compressed (0.952x ➖, 0↑ 0↓)
|
Contributor
File Sizes: PolarSignals ProfilingNo file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.934x ➖, 2↑ 1↓)
datafusion / vortex-compact (0.975x ➖, 0↑ 0↓)
datafusion / parquet (0.967x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.017x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.033x ➖, 0↑ 2↓)
duckdb / parquet (0.949x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMeNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.051x ➖, 0↑ 2↓)
datafusion / vortex-compact (1.019x ➖, 0↑ 0↓)
datafusion / parquet (1.033x ➖, 0↑ 1↓)
datafusion / arrow (1.039x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.012x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.021x ➖, 0↑ 0↓)
duckdb / parquet (1.001x ➖, 0↑ 0↓)
duckdb / duckdb (1.009x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.105x ❌, 0↑ 54↓)
datafusion / vortex-compact (1.098x ➖, 0↑ 44↓)
datafusion / parquet (1.102x ❌, 0↑ 46↓)
duckdb / vortex-file-compressed (1.084x ➖, 0↑ 30↓)
duckdb / vortex-compact (1.060x ➖, 2↑ 20↓)
duckdb / parquet (1.060x ➖, 0↑ 15↓)
duckdb / duckdb (1.067x ➖, 0↑ 25↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.954x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.830x ➖, 1↑ 0↓)
datafusion / parquet (0.976x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.003x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.887x ➖, 0↑ 0↓)
duckdb / parquet (0.973x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.993x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.026x ➖, 0↑ 3↓)
datafusion / parquet (0.991x ➖, 0↑ 0↓)
datafusion / arrow (0.989x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.148x ❌, 0↑ 20↓)
duckdb / vortex-compact (1.125x ❌, 0↑ 18↓)
duckdb / parquet (1.069x ➖, 0↑ 4↓)
duckdb / duckdb (1.017x ➖, 0↑ 2↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (0.997x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.990x ➖, 0↑ 0↓)
duckdb / parquet (0.981x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.979x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.911x ➖, 0↑ 0↓)
datafusion / parquet (1.058x ➖, 1↑ 3↓)
duckdb / vortex-file-compressed (1.001x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.992x ➖, 0↑ 0↓)
duckdb / parquet (0.969x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.003x ➖, 1↑ 2↓)
datafusion / parquet (0.989x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.970x ➖, 7↑ 0↓)
duckdb / parquet (0.998x ➖, 0↑ 1↓)
duckdb / duckdb (0.975x ➖, 2↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Clickbench on NVMEFile Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.853x ✅ unknown / unknown (0.951x ➖, 8↑ 1↓)
|
Contributor
Benchmarks: CompressionVortex (geomean): 1.004x ➖ unknown / unknown (1.007x ➖, 1↑ 4↓)
|
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.961x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.907x ➖, 2↑ 0↓)
datafusion / parquet (0.819x ➖, 6↑ 0↓)
duckdb / vortex-file-compressed (1.017x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.021x ➖, 0↑ 0↓)
duckdb / parquet (1.048x ➖, 0↑ 0↓)
Full attributed analysis
|
connortsui20
approved these changes
Apr 16, 2026
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/idempotent_dir-fast-path
branch
from
21dfaa0 to
95850b6
Compare
joseph-isaacs
added
the
action/benchmark
github-actions
Bot
removed
the
action/benchmark
Add a `dir: &Path` parameter to `download_many`. On entry it skips all downloads if `dir/.success` already exists; on success it writes that marker so subsequent runs skip the whole batch. Call sites updated: clickbench partitioned, public_bi bzips, vector_dataset train shards. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/idempotent_dir-fast-path
branch
from
18703fd to
762e4c6
Compare
AdamGS
reviewed
Apr 17, 2026
| convert_parquet_directory_to_vortex(&base_path, CompactionStrategy::Default).await?; | ||
| } | ||
| // All conversions are only meaningful for local file URLs. | ||
| if benchmark.data_url().scheme() != "file" { |
Contributor
There was a problem hiding this comment.
a bunch of this stuff is handled in the underlying benchmarks, if we want to have unified handling here, lets pull all of them out and document that on the trait,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have a
.successfile for dataset generate to speed up repeated benchmark runs