fix: linker converts providers/usesInheritance/usesOnChanges to features for directives#76
Merged
Brooooooklyn merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
…res for directives The directive linker was passing through a raw `features` property that doesn't exist on partial declarations. Replace with `build_features()` (already used by the component linker) so `providers`, `usesInheritance`, and `usesOnChanges` are correctly converted to their feature equivalents. - Close #66 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The directive linker was passing through a raw
featuresproperty thatdoesn't exist on partial declarations. Replace with
build_features()(already used by the component linker) so
providers,usesInheritance,and
usesOnChangesare correctly converted to their feature equivalents.Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Medium Risk
Changes directive codegen in the Angular partial declaration linker, which can affect runtime behavior if feature emission is incorrect, but the change is small and covered by new focused tests.
Overview
Fixes directive linking to compute the
featuresarray viabuild_features()(matching component linking) so directive partial declarations withproviders,usesInheritance, and/orusesOnChangesemit the correct feature calls (e.g.ɵɵProvidersFeature,ɵɵInheritDefinitionFeature,ɵɵNgOnChangesFeature).Adds regression tests covering each directive feature flag and the combined case to ensure provider references are preserved and the expected feature helpers appear in linked output.
Written by Cursor Bugbot for commit c946b5c. This will update automatically on new commits. Configure here.