fix: account for non-Angular decorators when inserting decls_before_class#63
Merged
Brooooooklyn merged 2 commits intomainfrom Mar 4, 2026
Merged
fix: account for non-Angular decorators when inserting decls_before_class#63Brooooooklyn merged 2 commits intomainfrom
Brooooooklyn merged 2 commits intomainfrom
Conversation
…lass When a class has non-Angular decorators (e.g., @log), the const declarations (_c0, etc.) were inserted between the decorator and the class statement, producing invalid syntax. Now checks decorator span positions to insert before any preceding decorators. Vite/Rolldown's built-in oxc_transformer handles the TS-to-JS conversion (type stripping, decorator lowering) downstream, so no additional transform step is needed in the Angular compiler. Also adds a custom decorator to the playground for testing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Add edge-case fixtures for components with non-Angular class decorators (single and multiple). Verifies the Angular compiler preserves custom decorators without breaking generated code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class has non-Angular decorators (e.g., @log), the const
declarations (_c0, etc.) were inserted between the decorator and
the class statement, producing invalid syntax. Now checks decorator
span positions to insert before any preceding decorators.
Vite/Rolldown's built-in oxc_transformer handles the TS-to-JS
conversion (type stripping, decorator lowering) downstream, so no
additional transform step is needed in the Angular compiler.
Also adds a custom decorator to the playground for testing.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Cursor Bugbot is generating a summary for commit 38d388d. Configure here.