fix(hmr): multiple updates happened when invalidate is called while multiple tabs open#16307
Merged
patak-cat merged 1 commit intoMar 29, 2024
Merged
Conversation
…ultiple tabs open
|
|
sapphi-red
added
feat: hmr
p3-minor-bug
Member
|
Oh, this is a very interesting one. Incredible there are still these kind of issues in Vite's HMR after all these years 🤯 |
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on ✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, remix, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest |
patak-cat
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While checking the flaky test I found this bug 🫠
Because
import.meta.hot.invalidateis called from the browser side, if multiple tabs are open, multipleimport.meta.hot.invalidaterequest is sent to server causing multiple updates.