fix: build.modulePreload.resolveDependencies is optimizable#16083
Conversation
|
|
|
|
||
| renderedDeps = resolvedDeps.map((dep) => { | ||
| let renderedDeps: number[] | ||
| if (renderBuiltUrl) { |
There was a problem hiding this comment.
If modulePreload.resolveDependencies returns a relative path to build.outDir, then it should be possible to use the else block.
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, remix, unocss, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-setup-catalogue, vitepress |
|
Resolved conflicts 👍 |
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, astro, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, remix, sveltekit, unocss, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress |
Description
The document of
build.modulePreload.resolveDependencieshad, but actually this wasn't true.
build.modulePreload.resolveDependenciesdoes not expect a relative path to thehostId. It expects a relative path tobuild.outDir. The result ofbuild.modulePreload.resolveDependenciesis passed totoOutputFilePathWithoutRuntimeortoOutputFilePathInJS.close #13169 (indirectly)
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).