Feature: docker image build workflow#13
Merged
kieranajp merged 6 commits intoJan 3, 2023
Merged
Conversation
Author
|
Also, tests are failing on my fork, what I need to do to fix them? Workflow with test run: https://github.com/CondensedTea/helm/actions/runs/3720027775/jobs/6309255414 |
# Conflicts: # action.yml
Member
|
Hey @CondensedTea, happy new year! Thank you for the submission and sorry for the delay in getting to it. Looks good from my side so I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
First, thanks for maintaining this action, it is really useful in my projects.
I noticed that every deploy 20-30 seconds spent on building action image, so I thought it could be optimised. Image is pushed to GHCR which is free right know.