Update Dockerfile to use 3.10 in PYTHONPATH#12
Merged
Conversation
Latest Alpine release has upgraded the python version to 3.10 (See: https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.16.0#Python_upgraded_to_3.10) As the PYTHONPATH is harcoded, the Dockerfile needs to be updated accordingly
and update the python path again
kieranajp
approved these changes
Dec 5, 2022
Member
kieranajp
left a comment
There was a problem hiding this comment.
Thank you - appreciate the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[UPDATE]
I found the same issue agan as the Dockerfile had only the major version in the FROM image.
I have pinned the alpine image and change the PYTHONEVN path accordingly
====
Latest Alpine release has upgraded the python version to 3.10 (See: https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.16.0#Python_upgraded_to_3.10)
As the PYTHONPATH is harcoded, the Dockerfile needs to be updated accordingly.
This fixes the issue of
aws clinot working:Please, review and merge ASAP, as this is a breaking change in some of our workflows.
Thanks!