feat: [MOB-121] Add LinkDomain to ActionCodeSettings#2
Merged
graeme-verticalscope merged 1 commit intoApr 16, 2025
Merged
Conversation
arsalan-vs
approved these changes
Apr 16, 2025
Author
|
For quick reference, here's how I created the tag. Run this on the the latest version of the patch branch to create your patch tag: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this change
Add the
LinkDomainfield to theActionCodeSettingsstruct, this new field enables migrating off of firebase dynamic links, which is deprecated and will be unsupported soon.See issue firebase#681, and original PR firebase#682
Unit test is updated to check that
linkDomainis set correctly in the action code settings map.What should reviewers focus on
I've created a branch
vs-patch-1-v4-15-2, to be the target branch for this change. I don't want to update themasterbranch because that will muddy our ability to keep the master branch in sync with the original repository.Plan for maintaining our fork is:
<patch-name>-<release-version><release-version>-vspatch.1(see go module versioning)replacefeature in go.mod to switch fl-core to our patched release version (see using forked package import in go)