Compiler classpath and DiagnosticCollector#2
Conversation
add ability to set options, such as a class path changed source version to 1.7
| public void setClassLoader(ClassLoader classLoader) { | ||
| this.classLoader = classLoader; | ||
| } | ||
| private ClassLoader classLoader = Compiler.class.getClassLoader(); |
There was a problem hiding this comment.
General recommendation: when you make a change in a project do not reformat the code, keep the tabbing. Otherwise the 'diff' will show a lot of lines deleted and reinserted and it is hard to assess the true nature of the modification.
|
Please remove the formatting change and follow the suggestions I gave about style (mainly have if/than/else structures explicitely rather than 'set default here instead of else branch / if/then return and omit else / return error'. If you do that I will be more than happy to merge your changes into the project. These changes seem to be very good. And a last comment: If there is any change in the code and there is no change in the test it means the quality of the code degraded. Create new test cases that test your changes. |
2 participants
adds ability to set and use a DiagnosticCollector
adds ability to set options, such as a class path
changed source version to 1.7