fix(perf): use modern tar and use node streaming utilities#130
Closed
ayuhito wants to merge 3 commits into
Closed
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cbf0c42 to
b67e5fb
Compare
styfle
reviewed
Feb 23, 2026
Member
styfle
left a comment
There was a problem hiding this comment.
Lets separate into two PRs
- Remove
promisepipeandstream-to-promise - Replace
tarwithmodern-tar
The first will be safe to merge but the second will require security audit.
Closed
Contributor
Author
|
Sorry for the delay! I'll go ahead and do that now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce the bundle size and removes 13 dependencies for Node natives and
modern-tar.tarwithmodern-tar. I noticedjust-bashusingmodern-tar, which prompted this PR.promisepipewithnode:stream/promises.stream-to-pipewithnode:stream/consumers.For example,
taradds 3MB to the final unpacked package size which makes up for most of total bundle already (4MB).Ref: https://npmgraph.js.org/?q=%40vercel%2Ffun#select=tar%407.5.7
I intended to split all separate changes into separate PRs, but since they are all so tiny I went with splitting them per commit which should also be reviewable. Apologies!
I think there are additional drop in improvements such as
debug-->obug,node-fetch-->native,stat-mode-->native, but I'd rather not grow the scope of this PR any larger.