Star rating value mismatch - #4
Closed
alecritson wants to merge 1 commit into
Closed
Conversation
The rating values where in the opposite order, value decreased with each up star. This fixes that issue
|
Thanks for this - originally I used a different approach for the hover styles that required the starts to be in the wrong order, I obviously didn't update my loop after! I've just checked over your code and I think a much simpler approach is warranted, which I've just done in c4c90fb - but thanks for the heads up! |
Author
|
Good shout on the simplification, don’t know how I didn’t see that! |
|
No worries! Not sure how I missed the fact that they we're still in the wrong order 😕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rating values for stars are in the opposite order, value decreases when it should be increasing. I've editing the settings template to fix this issue. Thanks for the fieldtypes though, really helpful! ⭐