Skip to content

Star rating value mismatch - #4

Closed
alecritson wants to merge 1 commit into
verbb:masterfrom
alecritson:fix-star-value
Closed

Star rating value mismatch#4
alecritson wants to merge 1 commit into
verbb:masterfrom
alecritson:fix-star-value

Conversation

@alecritson

Copy link
Copy Markdown

The rating values for stars are in the opposite order, value decreases when it should be increasing. I've editing the settings template to fix this issue. Thanks for the fieldtypes though, really helpful! ⭐

The rating values where in the opposite order, value decreased with
each up star. This fixes that issue
@joshangell

Copy link
Copy Markdown

Thanks for this - originally I used a different approach for the hover styles that required the starts to be in the wrong order, I obviously didn't update my loop after!

I've just checked over your code and I think a much simpler approach is warranted, which I've just done in c4c90fb - but thanks for the heads up!

@joshangell joshangell closed this Dec 3, 2014
@alecritson

Copy link
Copy Markdown
Author

Good shout on the simplification, don’t know how I didn’t see that!

@joshangell

Copy link
Copy Markdown

No worries! Not sure how I missed the fact that they we're still in the wrong order 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants