Skip to content

Add the missing SQLDatabase.alter(table: any SQLExpression) method#188

Merged
gwynne merged 4 commits into
mainfrom
add-missing-alter-table-builder-method
Apr 13, 2025
Merged

Add the missing SQLDatabase.alter(table: any SQLExpression) method#188
gwynne merged 4 commits into
mainfrom
add-missing-alter-table-builder-method

Conversation

@gwynne

@gwynne gwynne commented Apr 13, 2025

Copy link
Copy Markdown
Member

These changes are now available in 3.33.0

Each of the various query builders have overloads on SQLDatabase which accept any SQLExpression parameters, except for SQLAlterTableQueryBuilder. The missing SQLDatabase.alter(table: any SQLExpression) overload is now provided.

Additional changes:

  • Fixed several minor issues in the API docs.
  • The minimum required Swift version is now 5.10.

@gwynne gwynne added bug Something isn't working semver-minor Contains new APIs labels Apr 13, 2025
@gwynne
gwynne requested review from 0xTim, MahdiBM and ptoffy April 13, 2025 04:46
@gwynne
gwynne force-pushed the add-missing-alter-table-builder-method branch from c2af115 to 5a7d8b7 Compare April 13, 2025 04:48
@codecov

codecov Bot commented Apr 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e0b35ff) to head (374ac6d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         2636      2662   +26     
=========================================
+ Hits          2636      2662   +26     
Files with missing lines Coverage Δ
...uilders/Implementations/SQLAlterTableBuilder.swift 100.00% <100.00%> (ø)
...it/Builders/Implementations/SQLInsertBuilder.swift 100.00% <ø> (ø)
...s/Prototypes/SQLCommonTableExpressionBuilder.swift 100.00% <ø> (ø)
...it/Builders/Prototypes/SQLCommonUnionBuilder.swift 100.00% <ø> (ø)
.../Builders/Prototypes/SQLPartialResultBuilder.swift 100.00% <ø> (ø)
...LKit/Expressions/Clauses/SQLColumnDefinition.swift 100.00% <ø> (ø)
...ources/SQLKit/Expressions/Syntax/SQLFunction.swift 100.00% <100.00%> (ø)
Sources/SQLKit/Rows/SQLQueryEncoder.swift 100.00% <ø> (ø)

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gwynne
gwynne force-pushed the add-missing-alter-table-builder-method branch from 5a7d8b7 to 374ac6d Compare April 13, 2025 04:51
@gwynne
gwynne merged commit baf0d86 into main Apr 13, 2025
@gwynne
gwynne deleted the add-missing-alter-table-builder-method branch April 13, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working semver-minor Contains new APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants