Support the use of unions in subqueries#178
Merged
Merged
Conversation
… to bad design choices in the original union support (my bad), this turns out to be mildly annoying to actually use and extremely painful to follow in the actual implementation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 98 +1
Lines 2551 2565 +14
=========================================
+ Hits 2551 2565 +14
|
Member
Author
|
API breakage notes:
|
MahdiBM
reviewed
May 17, 2024
MahdiBM
approved these changes
May 17, 2024
MahdiBM
left a comment
There was a problem hiding this comment.
If you're sure about the API breakage.
Member
Author
|
I am, actually 🙂. Look at the definition of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are now available in 3.30.0
Adds support for the use of
UNIONqueries within subqueries. Unfortunately, thanks to iffy design choices on my part in the originalSQLUnionimplementation, the usage is slightly awkward. Example usage:This generates the following query:
Unfortunately, it is not possible to chain
.union()when usingSQLSubquery.select(_:); the call chain must start withSQLSubquery.union(_:).