fix: file descriptor leak in joinSandboxNetNs by ensuring fd is closed#610
Open
ashnaaseth2325-oss wants to merge 1 commit intourunc-dev:mainfrom
Open
fix: file descriptor leak in joinSandboxNetNs by ensuring fd is closed#610ashnaaseth2325-oss wants to merge 1 commit intourunc-dev:mainfrom
ashnaaseth2325-oss wants to merge 1 commit intourunc-dev:mainfrom
Conversation
Signed-off-by: ashnaaseth2325-oss <ashnaaseth2325@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #609
SUMMARY
This PR fixes a file descriptor leak in
joinSandboxNetNs()withinpkg/unikontainers/unikontainers.go. The function opened a network namespace file descriptor but never closed it, causing descriptors to accumulate over time in long-running processes.The change ensures the file descriptor is properly closed on both success and error paths, preventing resource exhaustion without altering runtime behavior.
FIX