docs: add code copy button for code blocks with no output#576
docs: add code copy button for code blocks with no output#576cmainas merged 2 commits intourunc-dev:main-pr576from
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @cmainas , can you allow the workflows to run ? |
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Hello @neo-0007 ,
thank you for this PR. The preview looks good with the copy button. I have added a comment about some changes which do not seem necessary.
Other than than, since https://github.com/urunc-dev/urunc/pull/432is still open, I would suggest we give another chance for the author to respond. If they respond, then we can merge the changes of this PR with #432 . Otherwise, we will just drop #432.
| @@ -6,14 +6,14 @@ | |||
| Light Theme: urunc | |||
There was a problem hiding this comment.
Are the changes in this file necessary?
There was a problem hiding this comment.
These changes were made by @MUFFANUJ so I did not removed them.
From what I see, these changes do not affect anything since only the casing was changed. I can remove those if you want.
I talked with the author of #432 here #482 (comment) , and he was okay with me taking this up. (ping @MUFFANUJ ) |
|
Hello @neo-0007 , could you rebase over main then, so we can merge it? |
Signed-off-by: anujkumar.singh <anujsinghhero292@gmail.com>
- fix navigation issues introduced in fb63bc5 - remove left toc bar auto expand in navigation sections - rename code blocks with output as console - add new contributor - Should fix: urunc-dev#431 Signed-off-by: Hrishikesh Gohain <hrishikeshgohain123@gmail.com>
neo-0007
force-pushed
the
feat/enable-copy/pr-432-rework
branch
from
b4df42c to
f84700c
Compare
|
Hi @cmainas, Rebased, Thanks :) |
PR: #576 Signed-off-by: anujkumar.singh <anujsinghhero292@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
- fix navigation issues introduced in fb63bc5 - remove left toc bar auto expand in navigation sections - rename code blocks with output as console - add new contributor - Should fix: #431 PR: #576 Signed-off-by: Hrishikesh Gohain <hrishikeshgohain123@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
PR: #576 Signed-off-by: anujkumar.singh <anujsinghhero292@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
- fix navigation issues introduced in fb63bc5 - remove left toc bar auto expand in navigation sections - rename code blocks with output as console - add new contributor - Should fix: #431 PR: #576 Signed-off-by: Hrishikesh Gohain <hrishikeshgohain123@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
3 participants
Description
This PR builds in top of #432
@MUFFANUJ implemented the feature and logic for:
.language-consolein custom css to disable copy button for code blocks with output ( reason in issue discussion )@neo-0007 Fixed the issues described in #432 (comment)
Related issues
How was this tested?
This was tested by locally running the mkdocs site:
After Change:
LLM usage
(N/A)
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).