Skip to content

flag: replace regexp use#2288

Merged
dearchap merged 1 commit intourfave:mainfrom
kolyshkin:no-regexp
Mar 21, 2026
Merged

flag: replace regexp use#2288
dearchap merged 1 commit intourfave:mainfrom
kolyshkin:no-regexp

Conversation

@kolyshkin
Copy link
Contributor

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Commit ec05a8d introduces the only (non-test) user of regexp package.
It is pretty easy to not use regexp here, so let's get rid of it.

References:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Testing

Assuming existing tests cover the change.

Release Notes

Remove regexp dependency.

@kolyshkin
Copy link
Contributor Author

@dearchap PTAL

@dearchap
Copy link
Contributor

@kolyshkin can you resolve the conflicts ?

Commit ec05a8d introduces the only (non-test) user of regexp package.
It is pretty easy to not use regexp here, so let's get rid of it.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@abitrolly
Copy link
Contributor

 		// v1 -> v2 migration warning zone:
		// Strip off anything after the first found comma or space, which
		// *hopefully* makes it a tiny bit more obvious that unexpected behavior is
		// caused by using the v1 form of stringly typed "Name".

What all this comment is about? Is it still actual for v3?

@dearchap
Copy link
Contributor

@abitrolly yes. Still valid.

@dearchap dearchap merged commit 58e99ee into urfave:main Mar 21, 2026
9 checks passed
@abitrolly
Copy link
Contributor

@kolyshkin how did you trace size changes? Perhaps we could use a CI/CD bot to evaluate PRs.

@kolyshkin
Copy link
Contributor Author

@kolyshkin how did you trace size changes?

See opencontainers/runc#5184 (comment) (about 500K)

@kolyshkin kolyshkin deleted the no-regexp branch March 22, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants