Merged
Conversation
Contributor
Author
|
@dearchap PTAL |
Contributor
|
@kolyshkin can you resolve the conflicts ? |
Commit ec05a8d introduces the only (non-test) user of regexp package. It is pretty easy to not use regexp here, so let's get rid of it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
What all this comment is about? Is it still actual for |
Contributor
|
@abitrolly yes. Still valid. |
dearchap
approved these changes
Mar 21, 2026
Contributor
|
@kolyshkin how did you trace size changes? Perhaps we could use a CI/CD bot to evaluate PRs. |
Contributor
Author
See opencontainers/runc#5184 (comment) (about 500K) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Commit ec05a8d introduces the only (non-test) user of regexp package.
It is pretty easy to not use regexp here, so let's get rid of it.
References:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Testing
Assuming existing tests cover the change.
Release Notes