Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cbuto
force-pushed
the
release/space1.16docs
branch
from
2854e0e to
3b93008
Compare
cbuto
force-pushed
the
release/space1.16docs
branch
from
4210fcf to
162ffdb
Compare
cbuto
force-pushed
the
release/space1.16docs
branch
from
162ffdb to
5284f6a
Compare
cbuto
force-pushed
the
release/space1.16docs
branch
from
5284f6a to
621f5e8
Compare
cbuto
force-pushed
the
release/space1.16docs
branch
from
621f5e8 to
48be365
Compare
cbuto
force-pushed
the
release/space1.16docs
branch
from
48be365 to
ab324d0
Compare
cbuto
force-pushed
the
release/space1.16docs
branch
from
ab324d0 to
e37dc7c
Compare
cbuto
force-pushed
the
release/space1.16docs
branch
from
657579d to
04446d8
Compare
Signed-off-by: rae sharp <8883519+tr0njavolta@users.noreply.github.com>
cbuto
force-pushed
the
release/space1.16docs
branch
from
652f274 to
923eac9
Compare
cbuto
force-pushed
the
release/space1.16docs
branch
from
f60e802 to
ef8f5fb
Compare
Member
markandersontrocme
left a comment
markandersontrocme
left a comment
There was a problem hiding this comment.
Small nits on being more explicit about Configuration values, and cloud selection
Comment on lines
+32
to
+40
| ```yaml | ||
| externalTLS: | ||
| host: proxy.example.com # Externally routable hostname for TLS certificates | ||
|
|
||
| router: | ||
| proxy: | ||
| service: | ||
| type: LoadBalancer | ||
| annotations: |
Member
There was a problem hiding this comment.
Should we specify this is the Spaces helm values?
Comment on lines
+41
to
+47
| # AWS NLB (see Cloud-Specific Annotations for other clouds) | ||
| service.beta.kubernetes.io/aws-load-balancer-type: external | ||
| service.beta.kubernetes.io/aws-load-balancer-scheme: internet-facing | ||
| service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: ip | ||
| ``` | ||
|
|
||
| See [Cloud-Specific Annotations](#cloud-specific-annotations) for GCP and Azure. |
Member
There was a problem hiding this comment.
Should this me a be more explicit this is for AWS and or provide tabs for AWS, GCP, Azure?
Comment on lines
+77
to
+88
| ```yaml | ||
| ingress: | ||
| provision: true | ||
| host: proxy.example.com | ||
| ingressClassName: "<your-ingress-class>" | ||
| # Annotations to add to the Ingress resource | ||
| annotations: {} | ||
| # Pod labels of the Ingress controller - used for network policy | ||
| podLabels: {} | ||
| # Namespace labels of the Ingress controller - used for network policy | ||
| namespaceLabels: {} | ||
| ``` |
Member
There was a problem hiding this comment.
Should we specify this is the Spaces helm values?
Comment on lines
+244
to
+246
| ### Install AWS Load Balancer Controller | ||
|
|
||
| The AWS Load Balancer Controller provisions a Network Load Balancer when you expose the spaces-router Service with the annotations in the next step. |
Member
There was a problem hiding this comment.
nit: this only applies to an AWS Space install
| - **Ingress is no longer provisioned by default.** The Ingress resource is now | ||
| controller-agnostic. All ingress-nginx specific annotations, labels, and the | ||
| hardcoded `ingressClassName: nginx` have been removed. To keep existing | ||
| ingress-nginx working, add the following to your Helm values: |
Member
There was a problem hiding this comment.
Suggested change
| ingress-nginx working, add the following to your Helm values: | |
| ingress-nginx working, add the following to your spaces Helm values: |
turkenf
reviewed
Mar 9, 2026
| **2. Create EnvoyProxy and GatewayClass** | ||
|
|
||
| Create an `EnvoyProxy` resource that the GatewayClass references. See the [Envoy | ||
| Gateway EnvoyProxy docs][envoy-proxy] for the full API and more examples. |
Contributor
There was a problem hiding this comment.
[envoy-proxy]: couldn't see the link definition for this reference.
turkenf
reviewed
Mar 9, 2026
|
|
||
| | Spaces Version | Tested Kubernetes Versions | | ||
| |----------------|----------------------------| | ||
| | 1.15 | 1.32, 1.33, 1.34 | |
Contributor
There was a problem hiding this comment.
Should we add a line for 1.16?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
make vale-file FILE=docs/path/to/file.mdlocally for files changed (or will fix Vale suggestions in review)Additional notes