Web cleanup#80
Merged
Merged
Conversation
There is no need to minify the json. It is impossible to review changes
when it is all scrunched on one line. This change was generated by running
`jq --tab site.webmanifest | sponge site.webmanifest` and you can verify
that by running:
$ diff -s <(git show HEAD:kdlp.underground.software/site.webmanifest) \
<(git show HEAD^:kdlp.underground.software/site.webmanifest | jq --tab)
Files /dev/fd/63 and /dev/fd/62 are identical
These were just the source images used to create the final .ico file which holds all the sizes in one file. No need to hang on to these files.
Instead of cluttering up the root of the kdlp.underground.software folder, we can put these in an assets folder and out of the way.
Contributor
|
Seems like some of the icons are going missing? |
Contributor
Author
|
can you be more specific? I don't see any missing icons |
Contributor
|
looks like the two favicon*.png files are deleted |
Contributor
Author
yes, that is correct. Those two files are not something that clients request. They get favicon.ico which is a combination file that includes both sizes. The two .png files were just the source for creating that .ico file as I explained in the commit that removed them. The favicon still shows up as expected because they are not used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spring cleaning on all the random files living in the root of the kdlp.underground.software folder
BEFORE:
AFTER: