Skip to content

rename additional contexts to use all lowercase#74

Merged
theyoyojo merged 2 commits into
masterfrom
lower_contexts
Apr 1, 2024
Merged

rename additional contexts to use all lowercase#74
theyoyojo merged 2 commits into
masterfrom
lower_contexts

Conversation

@charliemirabile

@charliemirabile charliemirabile commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

docker doesn't like additional contexts that contain capital letters so if we want compatibility we need to make this minor refactor.

Fixes: #32

Additional contexts should be named in all lowercase to improve compatibility.
Additional contexts should be named in all lowercase to improve compatibility.

@theyoyojo theyoyojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controversial

@theyoyojo theyoyojo merged commit 3ff68f5 into master Apr 1, 2024
@theyoyojo theyoyojo deleted the lower_contexts branch April 1, 2024 19:24
This was referenced Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consistent capitalization for docker args

2 participants