Conversation
nginx should not start until the other containers already have started.
Since the containers are networked together, the orbit container can be reached from nginx directly without having to pass through the host.
Now that nginx connects directly to the orbit container, there is no need to expose the port on the host.
Since the containers are networked together, the pop container can be reached from nginx directly without having to pass through the host.
Now that nginx connects directly to the pop container, there is no need to expose the port on the host.
Since the containers are networked together, the smtp container can be reached from nginx directly without having to pass through the host.
Now that nginx connects directly to the smtp container, there is no need to expose the port on the host.
nginx needs to reach the backend servers, but they do not need to be able to talk amoungst themselves. Introduce networks so that while nginx is part of all of them, each backend is only part of its own isolated one so it cannot reach any of the other backend servers.
Contributor
|
PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend containers do not need to have exposed ports on the host when nginx can instead just connect directly to them. The prior state of the art was necessitated primarily by the kludge for mail auth where having one hostname to resolve (the host instead of pop/smtp containers) made things more palatable.
The backend containers also do not need to be able to communicate with each other, only with nginx. Using networks can allows for this sort of isolation.