Confusion changes#47
Merged
Merged
Conversation
charliemirabile
requested changes
Mar 25, 2024
charliemirabile
requested changes
Mar 25, 2024
Contributor
|
also, since you are probably gonna need to force push to amend that last commit, if you could rebase on master too that would be great |
There were some unnecessary gray and white borders around the image.
The confusion div surrounding images embedded in the md docs is unnecessary. There should be a simple default styling for images in page bodies, as this is how most images will be shown on the site. The <br> after images is also unnecessary, as spacing like this should be left to the css.
Paragraphs in lists are set to margin for the sake of consistent spacing, but this made image margins a bit too cozy. Images in paragraphs in lists are given some margins to account for this.
michael-burke4
force-pushed
the
confusion-changes
branch
from
680e688 to
1f6e31a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21