Conversation
There are no callers for this function. Remove it from db.py
none of these queries are being used. Removing them will make it easier to implement the ORM which will make it easier to implement the dashboard.
Since there are no queries related to the table. It can be full removed.
The assignments table is not currently used for anything but viewing. It cannot be updated and no other tables or functionality reference it.
Since these functions are no longer called they and their format strings can be removed.
Since these functions are not called from anywhere, they can be removed.
Since this table is not reference anywhere, it can be removed.
All the other tables have nicknames that are explained.
theyoyojo
approved these changes
Mar 25, 2024
Contributor
PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of stuff in db.py is totally unused. Get rid of it to make switching to an ORM more painless.