Conversation
This allows debugging whether sessions work.
charliemirabile
force-pushed
the
auth_flow
branch
from
50c11e5 to
9909e36
Compare
the previous syntax wasn't properly redirecting to login.
This helper allows looking up a value provided in the query string of the url.
specifying target will seemlessly redirect you on once you successfully authenticate.
In the initial implementation a value of target could be provided that was a full url on a different host and it would be echoed back out in the Location header and redirect the user. There isn't a good use-case for that in the current application, other than potential maliciously crafted urls that would send a user to our login page and then elsewhere.
charliemirabile
force-pushed
the
auth_flow
branch
from
9909e36 to
4bfd850
Compare
theyoyojo
approved these changes
Mar 22, 2024
theyoyojo
left a comment
theyoyojo
left a comment
Contributor
There was a problem hiding this comment.
lgtm;lgtm;lgtb (looks good to me, let's get this merged, let's get this bread)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow seamless flow through login when trying to access a restricted resource.