Containerfiles: cleanup \ multi-line continuations to normalize last entry#36
Merged
Conversation
…entry Places where we use `\` to spread a command or string of commands across multiple lines should have a trailing line that does nothing so that all the real lines can look the same (i.e. all with \ or && \) so that future commit diffs can be tidy. If you ever have to add something to the end of one of these improperly terminated lists, you will need to edit the previous last entry line and ruin its git blame with useless noise. By creating this commit, I am creating such useless noise, but by doing it in a refactor commit that has no effect on behavior, I hope to help whoever comes across this while blaming to know they can skip it. This is not the commit you are looking for :) Single commands whose arguments are spread can just have `;` on the last line, and pipelines separated by `&&` can be terminated by the `:` command which is a no-op.
theyoyojo
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Places where we use
\to spread a command or string of commands across multiple lines should have a trailing line that does nothing so that all the real lines can look the same (i.e. all with \ or && ) so that future commit diffs can be tidy.If you ever have to add something to the end of one of these improperly terminated lists, you will need to edit the previous last entry line and ruin its git blame with useless noise.
By creating this commit, I am creating such useless noise, but by doing it in a refactor commit that has no effect on behavior, I hope to help whoever comes across this while blaming to know they can skip it. This is not the commit you are looking for :)
Single commands whose arguments are spread can just have
;on the last line, and pipelines separated by&&can be terminated by the:command which is a no-op.