extenginx: Fix redirect to https port#35
Merged
Merged
Conversation
putting the `return` directive at the top level means that all processing immediately stops (including location directives), so as written, it was impossible to actually add snippets to the http server that do anything. Moving the return statment into a `location /` block will allow it to continue to function as a fallback, but allows more specific overrides to be provided with additional location blocks in included snippets.
theyoyojo
approved these changes
Mar 20, 2024
theyoyojo
left a comment
theyoyojo
left a comment
Contributor
There was a problem hiding this comment.
Tested that this doesn't break existing redirect behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
putting the
returndirective at the top level means that all processing immediately stops (including location directives), so as written, it was impossible to actually add snippets to the http server that do anything.Moving the return statment into a
location /block will allow it to continue to function as a fallback, but allows more specific overrides to be provided with additional location blocks in included snippets.