orbit: switch production/dev toggle from environment to ARG#31
Merged
Conversation
By passing the value as an environment variable in the compose file it trashes the cache of all layers because that environment variable has to be set for all commands in all layers and could affect their behavior. This forces the builder to re-run everything including installing packages, building pip wheels etc. Since there are only two values, it isn't so bad -- once you have built with each at least once you will have a cache of both, but there is no reason to have two versions of each layer in the cache when really we only want to have it apply to the runtime environment. Passing the value as a build arg instead allows it to interact more carefully with the cache. Layers before the arg is mentioned in the Containerfile are blissfully unaware of it and because we really only want it for runtime, it can go right at the end and be used with an ENV instruction to introduce that environment variable for the only step that needs to be aware of it and rerun: setting the CMD. Fixes: 8bfc3ca ("orbit: specify production config boolean via appropriate container-compose")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By passing the value as an environment variable in the compose file it trashes the cache of all layers because that environment variable has to be set for all commands in all layers and could affect their behavior. This forces the builder to re-run everything including installing packages, building pip wheels etc. Since there are only two values, it isn't so bad -- once you have built with each at least once you will have a cache of both, but there is no reason to have two versions of each layer in the cache when really we only want to have it apply to the runtime environment. Passing the value as a build arg instead allows it to interact more carefully with the cache. Layers before the arg is mentioned in the Containerfile are blissfully unaware of it and because we really only want it for runtime, it can go right at the end and be used with an ENV instruction to introduce that environment variable for the only step that needs to be aware of it and rerun: setting the CMD.
Fixes: 8bfc3ca ("orbit: specify production config boolean via appropriate container-compose")