Cleanup compose files#28
Merged
Merged
Conversation
theyoyojo
previously approved these changes
Mar 17, 2024
charliemirabile
force-pushed
the
cleanup_compose
branch
3 times, most recently
from
a449610 to
b872975
Compare
This will make future adjustments easier to read.
This will make future adjustments easier to read.
this isn't nessecary and doesn't affect the behavior in any way but it makes the port specifications clear and self documenting.
…poses even though a hostname of localhost is the default for extenginx, specifying it explicitly consistently between all compose files is clearer.
charliemirabile
force-pushed
the
cleanup_compose
branch
from
b872975 to
e60656c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the more verbose syntax for mounts and ports makes the compose files slightly longer, but splitting the specifications onto multiple lines of clear key/value pairs allows the compose to be self documenting and will make future changes easier by making merge conflicts easier to resolve since git is only smart enough to handle context in the form of full lines.
Depends on #23