Denis enhanced#268
Merged
Merged
Conversation
charliemirabile
requested changes
Jul 15, 2025
theyoyojo
force-pushed
the
denis_enhanced
branch
2 times, most recently
from
c668287 to
e0bdf51
Compare
On the relevant deadline trigger, assign a zero score to a submission when mailman receives none or corrupt patches. Fixes #207 Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
denis_enhanced
branch
2 times, most recently
from
edec63a to
528d38c
Compare
charliemirabile
requested changes
Aug 29, 2025
compare DCO in each patch and cover letter to one created by combining the known username and hostname. Fixes #110 Signed-off-by: Joel Savitz <joel@underground.software>
Check RFC/lack thereof, PATH, vN consistency, and correct indexes Fixes: #262 Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
denis_enhanced
branch
from
528d38c to
265cd3d
Compare
Contributor
Author
|
Rebased PR passes the full test suite: https://github.com/underground-software/singularity/actions/runs/17447881328/job/49546522522 |
Contributor
Author
|
lets get this merged |
Contributor
Author
|
re: $HOSTNAME |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit 22c9694 ("denis: add notes tied to initial and final submissions"), denis can now add notes to tagged submissions on the initial and final submission deadlines. We can build on this scaffolding to implement the first automated grading features. In this PR, I've included an initial set of three: automatic zero for corrupt or missing patchsets, DCO check, and subject tag format check. More to come.
Fixes #207
Fixes #110
Fixes #262