Dashboard enhanced#264
Merged
Merged
Conversation
Use the last character of the status string to determine if the patchset was accepted, rejected, or there are not fatal issues such as whitespace errors, but don't reveal the full status string Signed-off-by: Joel Savitz <joel@underground.software>
charliemirabile
requested changes
Jul 8, 2025
charliemirabile
left a comment
charliemirabile
left a comment
Contributor
There was a problem hiding this comment.
Nice and bite (or should I say byte) sized. I think a small refactor in terms of how we fetch the info from the git notes is in order (and a few other nitpicks), but hopefully not too much to execute in a single rebase and push for this PR, and nothing that you won't be able to trivially rebase on top of for the subsequent ones.
Signed-off-by: Joel Savitz <joel@underground.software>
Signed-off-by: Joel Savitz <joel@underground.software>
Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
dashboard_enhanced
branch
from
732b01d to
4bb43fc
Compare
charliemirabile
requested changes
Jul 9, 2025
Store the grades for an assignment under the 'grade' ref linked to the final submission tag, e.g. to add a grade of '66' for user 'bob' assignment 'setup', one would run the following in the grading repo: $ git notes --ref=grade add setup_final_bob -m '66' $ git notes --ref=grade add setup_review1_bob -m '22' $ git notes --ref=grade add setup_review2_bob -m '66' $ git push origin refs/notes/* Assuming the connection to the grading repo is configured correctly, the grade will be immediately live for the student on the course dashboard Fixes: #259 Fixes: #258 Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
dashboard_enhanced
branch
5 times, most recently
from
caf4f9b to
1b65cdf
Compare
charliemirabile
left a comment
charliemirabile
left a comment
Contributor
There was a problem hiding this comment.
What do you think about this suggestion? Not doing "Request changes" since I am not going to insist on it, but I do feel like the current calculation is kinda spaghetti. But maybe this is too clever...
theyoyojo
force-pushed
the
dashboard_enhanced
branch
from
1b65cdf to
d3308c3
Compare
If the oopsie was used for this assignment, just use the final score. If only one student submitted, just use the final score as no reviews are required. If only two students submitted, count the single required review as the full 20% of the review grade. Fixes #260 Signed-off-by: Joel Savitz <joel@underground.software>
Right now this is just a fixed string. Soon, the note will contain automated test output. Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
dashboard_enhanced
branch
from
d3308c3 to
9de9b1d
Compare
charliemirabile
approved these changes
Jul 10, 2025
This was referenced Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking up #256 into smaller chunks part 1:
Fixes #255
Fixes #258
Fixes #259
Fixes #260
Fixes #232
Fixes #206