mailman: commit raw patches when patchset is corrupt#252
Merged
Conversation
theyoyojo
force-pushed
the
commit_corrupt_patches
branch
2 times, most recently
from
477e57e to
a048be3
Compare
Contributor
|
this probably should be three different commits 1) refactor out duplicate pathlib code 2) add suffix to each message to indicate severity 3) commit corrupt patch sets. The code looks good to me though. |
Signed-off-by: Joel Savitz <joel@underground.software>
No problem: . Warning: ? Rejected: ! Signed-off-by: Joel Savitz <joel@underground.software>
When a student submits a corrupt patchset, only the cover letter makes it to the grading repository so if an instructor wishes to examine the patch they must dig into the containers and find the email file. When mailman fails to apply a patch, the email patch file and all subsequent patchset in the patchset are committed to the repository as files and the resulting tag will contain these commits. Fixes: #251 Signed-off-by: Joel Savitz <joel@underground.software>
theyoyojo
force-pushed
the
commit_corrupt_patches
branch
from
a048be3 to
0e29fbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a student submits a corrupt patchset, only the cover letter makes it to the grading repository so if an instructor wishes to examine the patch they must dig into the containers and find the email file.
When mailman fails to apply a patch, the email patch file and all subsequent patchset in the patchset are committed to the repository as files and the resulting tag will contain these commits.
Fixes: #251