Fixes the issue where fullname was required #224
Merged
theyoyojo merged 1 commit intoFeb 10, 2025
Merged
Conversation
Contributor
|
Does not pass tests. Did you run them? |
Contributor
|
Please squash this into a single commit. Then it is ready to merge |
…he codebase assumes it can be NULL fixes #221. This fixes the issue where fullname was required even though the rest of the codebase assumes it can be NULL. One limitation is that if the test script is run twice, it will still hit a UNIQUE constraint failed: user.student_id error, since test.sh tries to create a user with student_id = 1234, which already exists from the first run. This happens because the database persists between runs in the Podman volume. Clearing the volume before running the tests would prevent duplicate users from previous runs. That said, this change should at least resolve the NOT NULL constraint failed: user.fullname issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #221. This fixes the issue where fullname was required even though the rest of the codebase assumes it can be NULL.
One limitation is that if the test script is run twice, it will still hit a UNIQUE constraint failed: user.student_id error, since test.sh tries to create a user with student_id = 1234, which already exists from the first run. This happens because the database persists between runs in the Podman volume. Clearing the volume before running the tests would prevent duplicate users from previous runs.
That said, this change should at least resolve the NOT NULL constraint failed: user.fullname issue!