Skip to content

denis: initial: update query to reflect new schema#164

Merged
michael-burke4 merged 2 commits into
masterfrom
denis_fix
Sep 23, 2024
Merged

denis: initial: update query to reflect new schema#164
michael-burke4 merged 2 commits into
masterfrom
denis_fix

Conversation

@charliemirabile

Copy link
Copy Markdown
Contributor

the assignment field in the submissions table no longer exists having been replaced by recipient to accomodate peer reviews.

Fixes: 60d73a7 ("mailman: unify all submissions under common table for dashboard")

the assignment field in the submissions table no longer exists having
been replaced by recipient to accomodate peer reviews.

Fixes: 60d73a7 ("mailman: unify all submissions under common table for dashboard")
The schema needs to be able to handle one or both of the reviwees being
null, and the code that inserts into the DB needs to account for lists
that are not exactly 3 elements long.

Fixes: 86353ae ("denis: record peer reveiew assignments")

@michael-burke4 michael-burke4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michael-burke4 michael-burke4 merged commit 3fd0a25 into master Sep 23, 2024
@michael-burke4 michael-burke4 deleted the denis_fix branch September 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants