Submission dashboard#103
Merged
Merged
Conversation
The dockerignore will prevent host build artifacts from getting put into the container image by accident. By handling SIGTERM explicitly, we can avoid having to wait ten seconds for podman-compose to resort to force-killing the container with SIGKILL. Signed-off-by: Joel Savitz <jsavitz@redhat.com>
charliemirabile
force-pushed
the
submission
branch
from
eab1c95 to
6595899
Compare
charliemirabile
force-pushed
the
submission
branch
2 times, most recently
from
bb3c166 to
ed8c3b1
Compare
…HLD` There is more than one way to not have to reap your children processes the simplest being explicitly setting `SIG_IGN` as the handler for `SIGCHLD`. However, unfortunately, doing this causes that setting to persist across `execve` which means that children inherit it and thus cannot reap their children (unless the explicitly reset it). This interferes with the behavior of functions like `system` or `popen`. Setting the `SA_NOCLDWAIT` flag on the handler involves using the more complicated `sigaction` interface, but the setting is properly reset during a call to `execve` so that children can properly manage their descendant processes.
We can rebuild him. The future is now. The singularity is here. Signed-off-by: Joel Savitz <jsavitz@redhat.com>
Give orbit access to the grades.db where the submissions live. A simple query can retrieve all submissions for a given student, enabling a basic submission dashboard. Signed-off-by: Joel Savitz <jsavitz@redhat.com>
Check that the patches apply and check whether any of them contain whitespace errors. Signed-off-by: Joel Savitz <jsavitz@redhat.com>
If the patches apply, we try to push a tag with the patches to a git remote running on the host.
The previous logic was a bit confusing. Explcitly enumerating the cases with explanatory comments hopefully makes this code easier to understand and maintain. No major functional changes, only maybe in some edge cases (like more than one email sent at once, but not addressed to a submission inbox).
charliemirabile
force-pushed
the
submission
branch
from
ed8c3b1 to
14576e7
Compare
This was referenced May 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #94
Fixes: #65
Fixes: #13