Conversation
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
+ Coverage 51.74% 52.42% +0.67%
==========================================
Files 64 64
Lines 1546 1568 +22
Branches 403 425 +22
==========================================
+ Hits 800 822 +22
+ Misses 744 737 -7
- Partials 2 9 +7
Continue to review full report at Codecov.
|
kuitos
reviewed
Sep 1, 2021
Member
kuitos
left a comment
There was a problem hiding this comment.
路由插入场景还需要做一下前置检查,必须符合这个条件,即 route 自身的 path 必须是 target 对应的 path 的子路由,不然直接 throw error,如
// 这里的 target path 必须是 /user 或者 /,如果是 /abc 这种直接抛异常,因为 /user/test 无法成为 /abc 的子路由
{ path: '/user/test', microApp: 'abc', target: '/user' }6b823a4 to
efe9a4a
Compare
kuitos
requested changes
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: insert route