Add Qwen model token limits for DashScope compatibility#3014
Open
wangguan1995 wants to merge 3 commits into
Open
Add Qwen model token limits for DashScope compatibility#3014wangguan1995 wants to merge 3 commits into
wangguan1995 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DashScope compatibility for Qwen models by adding explicit token limits for qwen-max and
qwen-plus, preventing claw from sending an oversized max_tokens value when routing through the
OpenAI-compatible provider.
Root Cause
rust/crates/api/src/providers/mod.rs only defines output token limits for a small set of known
models.
When qwen/qwen-max was used, the provider normalized it to qwen-max but did not find a
matching entry in model_token_limit(), so it fell back to the generic default in
max_tokens_for_model(). That default was larger than DashScope allows for qwen-max, causing
the API to reject requests with:
Changes
Two small additions in rust/crates/api/src/providers/mod.rs:
This ensures Qwen requests use a provider-specific max_tokens ceiling instead of the generic
fallback.
Verification
Before / After
Before
./target/debug/claw --model "qwen/qwen-max" prompt "hello"
✘ Request failed
error: api returned 400 Bad Request
InternalError.Algo.InvalidParameter: Range of max_tokens should be [1, 8192]
After
./target/debug/claw --model "qwen/qwen-max" prompt "hello"
✔ Done
Hello! How can I assist you with your Rust project today?