Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4075 +/- ##
==========================================
+ Coverage 47.26% 47.51% +0.24%
==========================================
Files 139 141 +2
Lines 29420 29534 +114
==========================================
+ Hits 13906 14032 +126
+ Misses 15514 15502 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5526a2b to
f5c63a2
Compare
f5c63a2 to
26d341c
Compare
26d341c to
28e536c
Compare
…t` for clarity and update references in tests
…ectly instead of using an `icomponent` switch; update corresponding tests for consistency.
…e variables for D-shaped and elliptical shapes
… integrate into DCLL and CCFE_HCPB classes
…ge; update plotting functions to display these metrics
28e536c to
0998992
Compare
…tency; remove unused Dshaped and Elliptical component test parameters
timothy-nunn
left a comment
There was a problem hiding this comment.
Just one question, then happy
|
I have verified that none of the existing variables that were being assigned have changed in this branch: |
timothy-nunn
left a comment
There was a problem hiding this comment.
Just one question about why the volumes are different for the D-shaped component between the old unit test and the new unit test.
| expected_vol_blkt_inboard=150.94724381968237, | ||
| expected_vol_blkt_outboard=869.2500537130913, | ||
| expected_vol_blkt_total=1020.1972975327737, |
There was a problem hiding this comment.
The old tests had slightly different values, any reason why?
Before:
expected_vol_blkt_outboard=691.06561956756764,
expected_volblkt=691.06561956756764,There was a problem hiding this comment.
This was down to the bad tests before as the inboard blanket was not accounted for in the output. Also because the reduction of the blanket area and volume is now in a separate function, this test is only testing for a full coverage blanket so the values are higher
| expected_vol_blkt_inboard=315.83946385183026, | ||
| expected_vol_blkt_outboard=1020.3677420460117, | ||
| expected_vol_blkt_total=1336.207205897842, |
There was a problem hiding this comment.
These volumes are the same as before
This pull request introduces improvements to the blanket structure output and plotting, as well as refactors unit tests for blanket half-height calculation. The main enhancements include a new plotting function for the blanket structure that displays both areas and volumes, streamlining of output methods, and simplification of the unit test for blanket half-height by removing unnecessary patching and parameters.
Checklist
I confirm that I have completed the following checks: