Skip to content

Default pint, composer-normalize, golangci-lint & phpstan to false#46

Merged
tangrufus merged 1 commit intomainfrom
default
Apr 11, 2026
Merged

Default pint, composer-normalize, golangci-lint & phpstan to false#46
tangrufus merged 1 commit intomainfrom
default

Conversation

@tangrufus
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 11, 2026 18:58
@tangrufus tangrufus enabled auto-merge (squash) April 11, 2026 18:58
@tangrufus tangrufus merged commit 3a74e39 into main Apr 11, 2026
4 checks passed
@tangrufus tangrufus deleted the default branch April 11, 2026 18:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates reusable GitHub Actions workflows to disable several linters/formatters by default when invoked via workflow_call, requiring explicit opt-in from callers.

Changes:

  • Set phpstan default input to false in the PHP lint workflow.
  • Set golangci-lint default input to false in the Go lint workflow.
  • Set pint and composer-normalize default inputs to false in the PHP format workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/lint-php.yml Defaults phpstan workflow input to false so PHPStan runs only when opted-in.
.github/workflows/lint-go.yml Defaults golangci-lint workflow input to false so golangci-lint runs only when opted-in.
.github/workflows/format-php.yml Defaults pint and composer-normalize workflow inputs to false so formatting runs only when opted-in.
Comments suppressed due to low confidence (1)

.github/workflows/lint-go.yml:24

  • golangci-lint-version input has an incorrect description (it currently says "Whether to run golangci-lint"), which is misleading for workflow_call consumers. Please update it to describe that this input controls the version of golangci-lint to install/use (e.g., latest or a specific vX.Y.Z).
      golangci-lint-version:
        description: Whether to run golangci-lint
        default: latest
        type: string

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants