Conversation
There was a problem hiding this comment.
Pull request overview
Updates reusable GitHub Actions workflows to disable several linters/formatters by default when invoked via workflow_call, requiring explicit opt-in from callers.
Changes:
- Set
phpstandefault input tofalsein the PHP lint workflow. - Set
golangci-lintdefault input tofalsein the Go lint workflow. - Set
pintandcomposer-normalizedefault inputs tofalsein the PHP format workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/lint-php.yml | Defaults phpstan workflow input to false so PHPStan runs only when opted-in. |
| .github/workflows/lint-go.yml | Defaults golangci-lint workflow input to false so golangci-lint runs only when opted-in. |
| .github/workflows/format-php.yml | Defaults pint and composer-normalize workflow inputs to false so formatting runs only when opted-in. |
Comments suppressed due to low confidence (1)
.github/workflows/lint-go.yml:24
golangci-lint-versioninput has an incorrect description (it currently says "Whether to run golangci-lint"), which is misleading for workflow_call consumers. Please update it to describe that this input controls the version of golangci-lint to install/use (e.g.,latestor a specificvX.Y.Z).
golangci-lint-version:
description: Whether to run golangci-lint
default: latest
type: string
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.