Comment out unused XorTMonadCombine#687
Merged
Merged
Conversation
This trait is currently unused, because the implicit def that uses it is commented out until we have separated weak/strong laws for `MonadCombine`. We probably shouldn't expose it if it doesn't satisfy our current `MonadCombine` laws.
Current coverage is
|
Contributor
|
👍 |
This was referenced Nov 21, 2015
Contributor
|
👍 |
adelbertc
added a commit
that referenced
this pull request
Dec 1, 2015
Comment out unused XorTMonadCombine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This trait is currently unused, because the implicit def that uses it is
commented out until we have separated weak/strong laws for
MonadCombine. We probably shouldn't expose it if it doesn't satisfy our currentMonadCombinelaws.