Skip to content

Remove dependency on nc for port checking - #484

Merged
dgdonut merged 4 commits into
twitter:masterfrom
jiridanek:jd_2020_04_remove_dependency_on_nc_481
Jul 29, 2021
Merged

Remove dependency on nc for port checking#484
dgdonut merged 4 commits into
twitter:masterfrom
jiridanek:jd_2020_04_remove_dependency_on_nc_481

Conversation

@jiridanek

Copy link
Copy Markdown
Contributor

fixes #481

@jiridanek

Copy link
Copy Markdown
Contributor Author

I've already signed the CLA at https://cla-assistant.io/twitter/scoot; not sure why the CLA check is not updating.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #484 (55b9c76) into master (f267b05) will decrease coverage by 1.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   53.24%   51.73%   -1.51%     
==========================================
  Files         116      123       +7     
  Lines        8127     8385     +258     
==========================================
+ Hits         4327     4338      +11     
- Misses       3291     3538     +247     
  Partials      509      509              
Impacted Files Coverage Δ
scheduler/setup/ports.go 100.00% <100.00%> (ø)
scheduler/setup/builder.go 0.00% <0.00%> (ø)
scheduler/setup/workers.go 0.00% <0.00%> (ø)
scheduler/setup/cmds.go 0.00% <0.00%> (ø)
scheduler/setup/api.go 0.00% <0.00%> (ø)
scheduler/setup/sched.go 0.00% <0.00%> (ø)
scheduler/setup/setup.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f267b05...55b9c76. Read the comment docs.

@codecov-commenter

codecov-commenter commented Jul 29, 2021

Copy link
Copy Markdown

Codecov Report

Merging #484 (28612da) into master (d37b89c) will decrease coverage by 1.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   52.59%   51.15%   -1.44%     
==========================================
  Files         113      120       +7     
  Lines        8381     8638     +257     
==========================================
+ Hits         4408     4419      +11     
- Misses       3464     3710     +246     
  Partials      509      509              
Impacted Files Coverage Δ
scheduler/setup/ports.go 100.00% <100.00%> (ø)
scheduler/setup/cmds.go 0.00% <0.00%> (ø)
scheduler/setup/builder.go 0.00% <0.00%> (ø)
scheduler/setup/setup.go 0.00% <0.00%> (ø)
scheduler/setup/workers.go 0.00% <0.00%> (ø)
scheduler/setup/sched.go 0.00% <0.00%> (ø)
scheduler/setup/api.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d37b89c...28612da. Read the comment docs.

@dgdonut
dgdonut merged commit 0d0c8a6 into twitter:master Jul 29, 2021
@jiridanek
jiridanek deleted the jd_2020_04_remove_dependency_on_nc_481 branch November 24, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

explicitly report missing dependencies in the environment, e.g. nc

4 participants