Change vite config path import#332
Merged
julien-deramond merged 1 commit intomainfrom Nov 18, 2023
Merged
Conversation
mdo
approved these changes
Nov 18, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way we import
resolvefrompathin the Vite config.This change is suggested to be consistent with the way Vite project imports itself
resolvein thevite.config.tsfile in its own documentation (e.g. https://vitejs.dev/guide/build.html#multi-page-app).It doesn't change anything in the way this example works. You can still run it locally this way:
npm run startnpm run buildChecklist
twbs/bootstrapto update the documentation accordingly. Edit: done in Docs: change vite config path import in vite guide bootstrap#39418