refactor(accordion): merge selectors for border-radius rule#39697
Merged
julien-deramond merged 2 commits intotwbs:mainfrom Feb 22, 2024
ZuBB:slimmer-accordion-css
Merged
refactor(accordion): merge selectors for border-radius rule#39697julien-deramond merged 2 commits intotwbs:mainfrom ZuBB:slimmer-accordion-css
border-radius rule#39697julien-deramond merged 2 commits intotwbs:mainfrom
ZuBB:slimmer-accordion-css
Conversation
louismaximepiton
approved these changes
Feb 21, 2024
Member
louismaximepiton
left a comment
There was a problem hiding this comment.
Seems more readable without drawback, I'm fine with it
julien-deramond
approved these changes
Feb 22, 2024
Member
julien-deramond
left a comment
There was a problem hiding this comment.
Thanks for the refactoring @ZuBB! LGTM
nickswalker
added a commit
to raceconditionrunning/raceconditionrunning.github.io
that referenced
this pull request
Jun 2, 2025
Fix accordion under new bootstrap releases due to changes in twbs/bootstrap#39697
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two groups of neighboring selectors within
_accordion.scssare applying the same style:border-radius: 0. I merged themMotivation & Context
I was reviewing the actual diff between 5.3.2 and 5.3.3 for
dist/css/bootstrap.cssand found two groups of neighboring selectors that were applying the same style. I decided to check if merging is possible and if there will be any profit (reduction of the filesize). Tests were OK, and the size was reduced by 23 bytes.Type of changes
Checklist
npm run lint)Live previews
https://deploy-preview-39697--twbs-bootstrap.netlify.app
Related issues
#37508