Skip to content

[WIP]: Add support for PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet#874

Closed
olokobayusuf wants to merge 2 commits into
tuist:mainfrom
muna-ai:main
Closed

[WIP]: Add support for PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet#874
olokobayusuf wants to merge 2 commits into
tuist:mainfrom
muna-ai:main

Conversation

@olokobayusuf

@olokobayusuf olokobayusuf commented Oct 29, 2024

Copy link
Copy Markdown

Resolves #838

Short description 📝

This PR adds support for PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet in Xcode 16.

Solution 📦

It builds upon #827 .

Implementation 👩‍💻👨‍💻

  • Add PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet type and support for deserializing from a .pbxproj file.
  • Update PBXFileSystemSynchronizedRootGroup.exceptions field type to abstract base PBXFileSystemSynchronizedExceptionSet type to cover PBXFileSystemSynchronizedBuildFileExceptionSet.
  • Add support for setting and serializing PBXFileSystemSynchronizedRootGroup.exception.
  • Add tests.

@pepicrft

Copy link
Copy Markdown
Contributor

Is this ready for review?

@olokobayusuf

Copy link
Copy Markdown
Author

@pepicrft not yet, I gotta add tests. Will try to get this finalized this weekend.

@adincebic

Copy link
Copy Markdown

@olokobayusuf are you still planning to merge this?

@fortmarek

Copy link
Copy Markdown
Member

Superseded by: #894

Thanks for the PR btw 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Xcode 16's PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet

4 participants