[ BUG] Fix false-positive on Azure storage "no public access" check for Selected networks#3029
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
chasprowebdev
changed the title
Contributor
|
🎉 This PR is included in version 3.70.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge chas/azure-public-access-check into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Fixes the Azure Storage public access check to treat “Selected networks” (publicNetworkAccess=Enabled + networkAcls.defaultAction=Deny) as not public, preventing false positives. Adds tests and updates remediation and evidence.
Deny, and fails (medium) only when public network access is effectively open (default actionAllow).networkAcls.defaultActiontoDeny; evidence now includesnetworkDefaultAction. Tests cover both pass and fail scenarios.Written for commit 35a7bbf. Summary will update on new commits.