CS-429 [Bug] - Attempt to upload meeting evidence showing a 401 Unauthorized error#2932
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@cubic-dev-ai Ultrareview |
Contributor
@chasprowebdev Starting ultrareview - a deeper analysis than a regular review. I'll post findings when complete. |
Contributor
There was a problem hiding this comment.
Ultrareview completed in 5m 26s
2 issues found across 3 files
Confidence score: 3/5
- There is a concrete user-impact risk in
apps/api/src/evidence-forms/evidence-forms.controller.ts: attribution fallback is tied to a hardcodedownerrole name rather than RBAC permissions, which can incorrectly reject valid org configurations with 400 responses. - A second moderate issue in the same controller allows fallback attribution to deactivated members because active-membership filtering is not enforced, which can misattribute uploads.
- Given the medium severity and solid confidence on both findings, this looks mergeable only with caution until attribution fallback logic is aligned with RBAC and active-user checks.
- Pay close attention to
apps/api/src/evidence-forms/evidence-forms.controller.ts- fallback attribution can reject valid permissioned setups and assign uploads to inactive members.
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Contributor
|
@cubic-dev-ai Ultrareview |
Contributor
@chasprowebdev Starting ultrareview - a deeper analysis than a regular review. I'll post findings when complete. |
Contributor
|
approved |
Contributor
|
🎉 This PR is included in version 3.66.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge chas/upload-submission-authorization into dev.
It was created by the [Auto Pull Request] action.
Summary by cubic
Fixes CS-429 by allowing session, API key, or service token auth for evidence uploads and attributing each submission to an active user. Stops 401s on upload, blocks attribution to deactivated owners, and returns 400 when no active org owner exists.
New Features
uploadSubmissionaccepts session, API key, or service token auth.Refactors
ActingUserResolverwith@Reqto resolve the acting user and passesuserIdto the service.uploadSubmissionnow takesuserIdinstead ofauthContext.Written for commit ec6a1fa. Summary will update on new commits.