automatically rebuild pycups - #2
Merged
Merged
Conversation
anothingguy
force-pushed
the
feat/rebuild_pycups
branch
from
July 22, 2026 11:03
54e2d8e to
4ceccc2
Compare
| pip install --no-binary :all: --force-reinstall pycups | ||
| ``` | ||
|
|
||
| Generated `.deb` packages already do this automatically (see `override_dh_virtualenv` in |
There was a problem hiding this comment.
but this runs on the runner, so it will still rebuild for the available instructions in the runner if you don't put any constraint
There was a problem hiding this comment.
I think you would need something like that at build step (for all versions)
DEB_CFLAGS_SET: "-march=x86-64 -mtune=generic"
DEB_CXXFLAGS_SET: "-march=x86-64 -mtune=generic"
CFLAGS: "-march=x86-64 -mtune=generic"
CXXFLAGS: "-march=x86-64 -mtune=generic"
| dh_virtualenv --python=$(SNAKE) --builtin-venv | ||
| # the prebuilt pycups wheel needs AVX; force it to build from source so | ||
| # the packaged venv also works on weak/old CPUs (e.g. Celeron J4125) | ||
| dh_virtualenv --python=$(SNAKE) --builtin-venv --extra-pip-arg="--no-binary=pycups" |
There was a problem hiding this comment.
actually it seems there is no binary wheel for pycups:
# pip download pycups --no-deps --only-binary=:all:
ERROR: Could not find a version that satisfies the requirement pycups (from versions: none)
ERROR: No matching distribution found for pycups
so it gets build everytime
so no need for this override, just need flags at higher level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.