Skip to content

Add filter for Closure functions#102

Merged
chadicus merged 4 commits intotraderinteractive:masterfrom
akoryak:closures
Sep 4, 2024
Merged

Add filter for Closure functions#102
chadicus merged 4 commits intotraderinteractive:masterfrom
akoryak:closures

Conversation

@akoryak
Copy link
Copy Markdown
Contributor

@akoryak akoryak commented Aug 29, 2024

What does this PR do?

Add filter for Closure functions

Checklist

  • [ x ] Pull request contains a clear definition of changes
  • [ x ] Tests (either unit, integration, or acceptance) written and passing
  • [ x ] Relevant documentation produced and/or updated

@akoryak akoryak force-pushed the closures branch 5 times, most recently from af39c04 to 9603767 Compare August 29, 2024 20:19
@akoryak akoryak marked this pull request as ready for review August 29, 2024 20:21
@akoryak akoryak requested a review from a team as a code owner August 29, 2024 20:21
Copy link
Copy Markdown
Contributor

@chadicus chadicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right library for the closures filter class, but i'll defer to others.
Be sure to update the README.md file with instructions and usage examples

@akoryak
Copy link
Copy Markdown
Contributor Author

akoryak commented Sep 3, 2024

I'm not sure this is the right library for the closures filter class, but i'll defer to others. Be sure to update the README.md file with instructions and usage examples

  1. updated the documentation
  2. It doesn't have much sense to me to create new git repository with ~90% duplication for just one simple filter function. Second reason I why I added it here is that I don't see any use case for this closure filter be used standalone

chrisryan
chrisryan previously approved these changes Sep 3, 2024
chrisryan
chrisryan previously approved these changes Sep 3, 2024
chrisryan
chrisryan previously approved these changes Sep 4, 2024
Co-authored-by: Chad Gray <1182337+chadicus@users.noreply.github.com>
Co-authored-by: Chad Gray <1182337+chadicus@users.noreply.github.com>
@chadicus chadicus merged commit 4cb52c7 into traderinteractive:master Sep 4, 2024
@akoryak akoryak deleted the closures branch September 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants