[pull] main from itigges22:main#48
Merged
Merged
Conversation
Request-derived file paths (syntax-check filenames, Java class/package names) were already constrained — _safe_overlay_path rejects absolute and '..' paths, and the Java identifiers come from restrictive regexes — but those guards raise instead of transforming the value, which py/path-injection taint tracking cannot follow. Every language PR that touched _syntax_check_impl therefore shipped with new high-severity alerts to dismiss by hand (#140, #141), and alert 510 sat open against the java branch. _contained_path() joins under the workspace and applies the normpath + prefix check CodeQL models as a sanitizer; all ten filename-derived writes and both Java path builders now go through it. Doubles as real defense-in-depth for the Java identifiers, which previously relied on regex shape alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )